Fix warnings-as-errors. #5409
Draft
Fix warnings-as-errors. #5409
+5
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teo-tsirpanis
commented
Dec 17, 2024
| FilterBuffer::BufferOrView::BufferOrView(BufferOrView&& other) { | ||
| underlying_buffer_.swap(other.underlying_buffer_); | ||
| view_.swap(other.view_); | ||
| std::swap(is_view_, other.is_view_); |
There was a problem hiding this comment.
We were accessing is_view_ while unititialized. A default move constructor suffices here.
teo-tsirpanis
force-pushed
the
teo/fix-werrors
branch
from
510f7ba to
2ccf242
Compare
teo-tsirpanis
commented
Dec 18, 2024
| @@ -85,9 +87,7 @@ FilterPipeline::FilterPipeline( | |||
| max_chunk_size_ = other.max_chunk_size_; | |||
| } | |||
|
|
|||
| FilterPipeline::FilterPipeline(FilterPipeline&& other) { | |||
| swap(other); | |||
There was a problem hiding this comment.
Same problem as before. The compiler looked through swap and saw uninitialized member access.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5389.
TYPE: NO_HISTORY