Result tile wait_all should block on the async i/o result #5446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rroelke
approved these changes
Feb 12, 2025
|
/backport to release-2.27 |
|
Started backporting to release-2.27: https://github.com/TileDB-Inc/TileDB/actions/runs/13330153062 |
shaunrd0
added a commit
that referenced
this pull request
Mar 3, 2025
)" This reverts commit d8bbb8b.
github-actions bot
pushed a commit
that referenced
this pull request
Mar 4, 2025
)" This reverts commit d8bbb8b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @ihnorton has noticed while auditing the code in #5401 , in result tile destructor we were waiting on
data()instead offiltered_data()for the async task to have finished. This was a leftover from the previous version of the code (before the split between part 1 and 2), where we were also unfiltering in an async fashion, sodata()was also blocking waiting for the unfiltering shared future to be done.This PR fixes this by waiting just for the I/O task to be done.
TYPE: IMPROVEMENT
DESC: Result tile wait_all should block on the async I/O result