Add Enumeration::index_of API
#5482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I'll also add that for tables, we (currently?) treat attributes with enumerations as columns of the enumeration data type, and then we have to map inserted values to the keys. Similarly we build our own hash map of value to key in order to do this, this API will make this process more efficient as well. |
davisp
requested changes
Mar 19, 2025
Contributor
davisp
left a comment
davisp
left a comment
There was a problem hiding this comment.
That... is significantly simpler than I was expecting. Nice work!
Though we should add tests of the C++ API as well. They look right to me, but we should also have tests to make sure they continue to work.
XanthosXanthopoulos
force-pushed
the
xan/sc-64451/expose-enumeration-index-of
branch
from
11ba58c to
4b4eef4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Enumeration::index_ofAPI which returns anstd::optional<uint64_t>containing the internal index of a value in an Enumeration if it exists.User code who needs to extend an enumeration given a list of values need to recreate the internal hash map structure to efficiently find which values are missing from the enumeration. Also remapping the indexes from a subset of values to the values the enumeration holds also requires the creation of the values hash map. Providing access to the internal hash map of the enumeration eliminates the need to recreate the map which might me an expensive step.
TYPE: FEATURE
DESC: Add
Enumeration::index_ofAPI