-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to 1.16 and remove unnecessary pinning #7
Conversation
# https://github.com/bioconda/bioconda-utils/blob/28a4dda0257b436d881da7717a88d75d6bf3067e/bioconda_utils/bioconda_utils-conda_build_config.yaml | ||
pin_run_as_build: | ||
m2w64-htslib: | ||
max_pin: x.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pin_run_as_build
and run_exports
are different mechanisms for achieving the same result, ie pinning the runtime dependency to use the same version at build time. This recipe already uses run_exports
, so also including pin_run_as_build
is redundant. Also, conda-forge has decided to prefer run_exports
over pin_run_as_build
Note that bioconda continues to include htslib
in its pin_run_as_build
in conda_build_config.yaml
.
However, that is a different situation. Their conda_build_config.yaml
is applied when building any bioconda recipe, whereas the one in this feedstock is only applied for building this recipe. Thus if a bioconda recipe is for some reason built against a very old htslib that doesn't have run_exports
, it would still be pinned properly at runtime
max_pin: x.x | ||
|
||
m2w64_htslib: | ||
- 1.15.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unnecessary for various reasons.
First, as above, this conda_build_config.yaml
is only applied when building the recipe in this feedstock. My original motivation for including this was to match the upstream bioconda conda_build_config.yaml
, but I now realize that this wasn't achieving the same goal. Since it only applies to this recipe, it only pins it for this recipe, and is thus just an additional place where we need to manually bump the version.
Second, bioconda no longer pins htslib globally (bioconda/bioconda-utils#917) since it has relaxed the htslib pins for all existing recipes (bioconda/bioconda-recipes#42895)
Also, for documentation, here is how I calculated the sha256: wget https://github.com/TileDB-Inc/m2w64-htslib-build/releases/download/1.16-0/m2w64-htslib-1.16-0.tar.gz
openssl sha256 m2w64-htslib-1.16-0.tar.gz
## SHA2-256(m2w64-htslib-1.16-0.tar.gz)= ac6a03e561eba22b9de0fd93e6b3d5aea0c72a5981e6a8157a24c8799bd3a8aa |
…nda-forge-pinning 2024.01.04.16.29.16
I recently rebuilt m2w64-htslib with htslib 1.16
TileDB-Inc/m2w64-htslib-build#3
https://github.com/TileDB-Inc/m2w64-htslib-build/releases/tag/1.16-0
motivation: TileDB-Inc/tiledb-vcf-feedstock#106