Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update TileDB-VCF to 0.29.0 #111

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Conversation

awenocur
Copy link
Contributor

No description provided.

Copy link

This pull request has been linked to Shortcut Story #41337: Update Core to 2.20.1.

@jdblischak
Copy link
Collaborator

Need to fix the sha256:

RuntimeError: SHA256 mismatch: '9c160f2435bff60ff53401fbb72cd9d061a8af073ab37c0e544bcf2084cfcbe7' != '25c1f2c5c8e3846ebc3de0ce7069b365dc22ffadede9036d8338a072eabc9137'

@jdblischak
Copy link
Collaborator

The linux-64 job is failing with the same Python 3.7 error we saw last week in TileDB-Inc/tiledbsoma-feedstock#83

include/python3.7m/Python.h:44:10: fatal error: crypt.h: No such file or directory

I think it's time to drop the Python 3.7 build just like we did for tiledbsoma-feedstock. cc @ihnorton @Shelnutt2

@Shelnutt2
Copy link
Member

The linux-64 job is failing with the same Python 3.7 error we saw last week in TileDB-Inc/tiledbsoma-feedstock#83

include/python3.7m/Python.h:44:10: fatal error: crypt.h: No such file or directory

I think it's time to drop the Python 3.7 build just like we did for tiledbsoma-feedstock. cc @ihnorton @Shelnutt2

Lets drop it!

@ihnorton ihnorton closed this Feb 27, 2024
@ihnorton ihnorton reopened this Feb 27, 2024
@ihnorton
Copy link
Member

Re-running CI to check sc-38823

@jdblischak
Copy link
Collaborator

@awenocur you can drop the py37 build by deleting the following from conda_build_config.yaml and then rerendering (note that this will also add a py311 build, which should be fine)

numpy:
- 1.21 # [linux]
- 1.22
- 1.22
- 1.22
python:
- 3.7.* *_cpython # [linux]
- 3.8.* *_cpython
- 3.9.* *_cpython
- 3.10.* *_cpython
python_impl:
- cpython # [linux]
- cpython
- cpython
- cpython

@ihnorton
Copy link
Member

@awenocur please also re-render. this run failed with sc-38823, but it picked up the old build not the new one with the updated SDK dependencies.

@jdblischak
Copy link
Collaborator

Please rebase onto master to include 9ba78d5 from #112, which dropped the linux-64 py37 build

@jdblischak
Copy link
Collaborator

More conda solver errors when trying to build the Python client:

Until we move away from pyarrow 11, I suspect the conda solver errors will continue to be problematic:

pyarrow:
- 11.*
pin_run_as_build:
pyarrow:
min_pin: x
max_pin: x

arrow 11 is no longer receiving the conda-forge migrator updates, so it isn't built against the latest aws-sdk-cpp versions, and thus is unable to be installed in the same environment as tiledb 2.20

https://github.com/conda-forge/arrow-cpp-feedstock/blob/161d0c0ef5259f93699c4c9d0b63816a872c6d1f/conda-forge.yml#L4-L9

@jdblischak jdblischak mentioned this pull request Mar 5, 2024
@ihnorton ihnorton marked this pull request as ready for review March 8, 2024 04:37
@ihnorton ihnorton merged commit 5f11910 into TileDB-Inc:master Mar 8, 2024
3 of 5 checks passed
@ihnorton
Copy link
Member

ihnorton commented Mar 8, 2024

I believe we can fix the osx-arm64 conflict in a build-bump by making the pyarrow >= condition depend on python version.

@jdblischak
Copy link
Collaborator

I believe we can fix the osx-arm64 conflict in a build-bump by making the pyarrow >= condition depend on python version.

The error is:

ImportError: cannot import name 'set_timezone_db_path' from 'pyarrow.lib' (/Users/runner/miniforge3/conda-bld/tiledb-vcf_1709872988870/_build_env/venv/lib/python3.9/site-packages/pyarrow/lib.cpython-39-darwin.so)

It's unclear to me why only osx-arm64 would need a different pyarrow version for different python versions. My initial guess would be a cross-compilation problem, since osx-arm64 is the only cross-compiled job in this feedstock.

@jdblischak
Copy link
Collaborator

It's unclear to me why only osx-arm64 would need a different pyarrow version for different python versions.

The osx-arm64 build was fixed in in #114

In the failing build in this PR, pyarrow 11 was installed in the build env and pyarrow 15 in the host env.

In the passing build from #114, pyarrow 15 was installed in both the build and host envs.

Honestly unclear why pyarrow 11 was installed in the build env in this PR. It didn't have any minimum or maximum contraints in the build requirements, the same as in #114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants