Test out vcpkg VCF rework #145
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dudoslav
requested review from
ihnorton,
jdblischak and
Shelnutt2
as code owners
jdblischak
reviewed
Dec 4, 2024
There was a problem hiding this comment.
@dudoslav thanks for pushing this forward! Great to see the progress you've made.
| @@ -29,10 +29,15 @@ outputs: | |||
| - git | |||
| - cmake | |||
| - make # [not win] | |||
| - htslib >=1.15 # [not win] | |||
There was a problem hiding this comment.
Shouldn't this only be required when cross-compiling, ie the osx-arm64 build?
Suggested change
| - htslib >=1.15 # [not win] | |
| - htslib >=1.15 # [build_platform != target_platform] |
There was a problem hiding this comment.
I think yes, and also it only needs to be in host requirements.
added 7 commits
December 10, 2024 15:26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test out build for the VCF build rework