Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expose_container_content #34

Conversation

kaamaurice
Copy link
Collaborator

Changelog Description

expose_container_content seems very confusing since the refactor.
So this is my suggestion.

Copy link
Owner

@Tilix4 Tilix4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tilix4 Tilix4 merged commit 9ef94a9 into Tilix4:re_outliner_entities Apr 26, 2023
Tilix4 added a commit that referenced this pull request Apr 26, 2023
* Refactor: Drop outliner_entity for more universal system

* rewrite expose_container_content (#34)

---------

Co-authored-by: kaa <kaalium@gmail.com>
Tilix4 added a commit that referenced this pull request May 5, 2023
* Refactor: Drop outliner_entity for more universal system

* rewrite expose_container_content (#34)

---------

Co-authored-by: kaa <kaalium@gmail.com>
Tilix4 added a commit that referenced this pull request May 10, 2023
* fix already relative paths

* added OSError exception for make relative path

* refactor for loops in one

* fix not statement with filepath.startswith

* refactor list concat with itertools chain

---------

Co-authored-by: kaamaurice <kaalium@gmail.com>
Tilix4 added a commit that referenced this pull request Jun 1, 2023
* Refactor: Drop outliner_entity for more universal system

* rewrite expose_container_content (#34)

---------

Co-authored-by: kaa <kaalium@gmail.com>
Tilix4 added a commit that referenced this pull request Jun 1, 2023
* fix already relative paths

* added OSError exception for make relative path

* refactor for loops in one

* fix not statement with filepath.startswith

* refactor list concat with itertools chain

---------

Co-authored-by: kaamaurice <kaalium@gmail.com>
Tilix4 added a commit that referenced this pull request Oct 17, 2023
* Refactor: Drop outliner_entity for more universal system

* rewrite expose_container_content (#34)

---------

Co-authored-by: kaa <kaalium@gmail.com>
Tilix4 added a commit that referenced this pull request Oct 17, 2023
* fix already relative paths

* added OSError exception for make relative path

* refactor for loops in one

* fix not statement with filepath.startswith

* refactor list concat with itertools chain

---------

Co-authored-by: kaamaurice <kaalium@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants