Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CustomAspectRatio as Selectable Option #344

Merged
merged 2 commits into from
Apr 21, 2019
Merged

Add CustomAspectRatio as Selectable Option #344

merged 2 commits into from
Apr 21, 2019

Conversation

anonymouz4
Copy link
Contributor

No description provided.

@TimOliver
Copy link
Owner

Thanks for the PR! But why is this necessary exactly? What sort of use-case are you thinking about?

@anonymouz4
Copy link
Contributor Author

anonymouz4 commented Apr 7, 2019

Well I build a extensive Snapchat Tweak and one certain Aspect Ratio is used by the image Viewer.
So if the image isn't in the certain aspect ratio, some parts are cut away, so I used a custom ratio.

Problem was that if someone moved the grid, he wouldn't be able to return to the custom Aspect Ratio I set. So I added a Selectable Option

And the custom Name is just so he knows that that aspect ratio is the intended one for the app.

@TimOliver
Copy link
Owner

Hmm. Okay! I see what you mean.

Admittedly, I was always wanting to keep the concept of custom aspect ratios internal. I'll approve it now, but I'll modify it so that "Custom" isn't visible unless it is non-nil, otherwise this changes the base behaviour of the library quite a lot.

In future, I think I need to revisit the whole way aspect ratios are handled in this app. It's pretty obvious an enum isn't flexible for a lot of use cases here.

Thanks for the PR!

@TimOliver TimOliver merged commit 0a9f741 into TimOliver:master Apr 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants