Futz with the build #409
Futz with the build #409
Conversation
| ThisBuild / homepage := Some(url("https://github.com/TimWSpence/cats-stm")) | ||
|
|
||
| ThisBuild / scmInfo := Some( | ||
| ScmInfo(url("https://github.com/TimWSpence/cats-stm"), "git@github.com:TimWSpence/cats-stm.git") | ||
| ) |
There was a problem hiding this comment.
This is set automatically. Actually with more info then you've set here I believe 😆
| .settings( | ||
| javacOptions ++= Seq("-source", "1.8", "-target", "1.8") | ||
| ) |
There was a problem hiding this comment.
You don't have java code in your project do you?
There was a problem hiding this comment.
Btw this will also be set automatically in a future release.
There was a problem hiding this comment.
Woops, you do have Java.
| ThisBuild / scmInfo := Some( | ||
| ScmInfo(url("https://github.com/TimWSpence/cats-stm"), "git@github.com:TimWSpence/cats-stm.git") | ||
| ) | ||
| ThisBuild / tlJdkRelease := Some(8) |
There was a problem hiding this comment.
Does this set the javac target option?
There was a problem hiding this comment.
Well, actually no :) it sets the --release flag which has superseded that, but anyway.
|
Sorry @armanbilge, just saw this! I thought I had approved it to run the build but it doesn't seem to have done it... |
| @@ -34,6 +29,7 @@ lazy val `cats-stm` = tlCrossRootProject | |||
| core, | |||
| benchmarks, | |||
| docs, | |||
| unidoc, | |||
There was a problem hiding this comment.
What is going on with this diff? That is already aggregated on main
There was a problem hiding this comment.
Lol, I opened this PR before you did that, and it doesn't detect the merge conflict.
Anyway, nothing critical in here, just some things I noticed while looking at your build. Also you'll still need to apply add the settings from typelevel/sbt-typelevel#214 (comment) to fix your publishing.
There was a problem hiding this comment.
Haha yeah, it's on my TODO list. Thanks!
|
Thanks so much @armanbilge! :) |
No description provided.