Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dataStringComparisonBehavior parameter to reference data put/update spec #4

Merged
merged 2 commits into from
Mar 15, 2018

Conversation

yeskarthik
Copy link

@yeskarthik yeskarthik commented Mar 15, 2018

Added dataStringComparisonBehavior parameter to reference data put/update spec.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@yeskarthik
Copy link
Author

@sandshadow approved the PR in-person, tested with ManagementClientSampleApp, fixed grammar.

@yeskarthik yeskarthik merged commit 06794ac into master Mar 15, 2018
sandshadow pushed a commit that referenced this pull request Aug 20, 2018
…re#2378)

* Azure Container Registry Auto Build Feature Swagger and examples

* Updated the Readme to include the new build swagger under default tag

* Removed Required attribute on the route parameters

* Removed the Required attribute for the global parameters and corrected the ProvisioningState

* Updated the readme to fix the CI failures

* Fixed the ref errrors on the global parameters

* Made getLogLink as POST operation

* Added a new getSourceUploadUrl API

* Renamed ImageName to RepositoryName and removed 404 status code

* Removed log parameters for GetBuildLogLink API

* Removed OAuth APIs

* Swagger team review feedback

* Added listBaseImageDependencies to build step and separated PUT and PATCH object types

* Removed Context Path for Quick build

* Removed separate build parameters in QuickBuild object

* Removed some of the unused properties and fixed the response payload of Queue build request

* API updates for base image dependencies

* Making list arguments pageable.

* Added a new POST action for build definition and fixed the Azure resource schema

* The parent resource swagger uses Resource for TrackedResource. So changed according to it

* Renamed the resource buildDefinition to buildTask

* Updated readme to include parent resource swagger

* Added range validation for timeout parameter

* Adding imageNames, No-cache and git commit and image update trigger

* Rebased with remote and fixed the Error schema

* Removed obsolete properties and actions

* Added registry property to BaseImageDependecy

* Update image descriptor

* update examples

* Improve examples

* Revert a change in formatting

* A few improvements and fixes (#4)

* A few improvements and fixes

* Fix the description for build arguments

* Remove error schema

* use 2017-10-01 tag

* Add default response back

* Fix Error status, fix version (#5)

* Remove error schema

* Add default response back

* Fix abandoned as system error

* Fix Error status

* Use preview tag

* Fix tag

* Remove error response schema as they are not used

* Fix default valus (#6)

* Fix CI (#7)

* Add python sdk version

* Add preview to namespace

* Remove an example

* Fix examples (#8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants