Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/1310 #1372

Merged
merged 6 commits into from
Feb 5, 2025
Merged

Fix/1310 #1372

merged 6 commits into from
Feb 5, 2025

Conversation

TomCools
Copy link
Contributor

Add diagrams for #1310.

@TomCools
Copy link
Contributor Author

@triceo or @rsynek , would appreciate your feedback on these before I start on the Connected ranges collectors

@triceo
Copy link
Contributor

triceo commented Jan 31, 2025

I love it! Simple, clear. No comments.

@TomCools TomCools marked this pull request as ready for review February 4, 2025 15:16
@TomCools
Copy link
Contributor Author

TomCools commented Feb 4, 2025

Added diagram for Connected Ranges and simplified the initial documentation to use temporal.

Christopher-Chianelli
Christopher-Chianelli requested changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@Christopher-Chianelli Christopher-Chianelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use snake case for user Python attributes.

docs/src/modules/ROOT/pages/constraints-and-score/score-calculation.adoc Outdated Show resolved Hide resolved
docs/src/modules/ROOT/pages/constraints-and-score/score-calculation.adoc Outdated Show resolved Hide resolved
docs/src/modules/ROOT/pages/constraints-and-score/score-calculation.adoc Outdated Show resolved Hide resolved
docs/src/modules/ROOT/pages/constraints-and-score/score-calculation.adoc Outdated Show resolved Hide resolved
@TomCools @Christopher-Chianelli
Update docs/src/modules/ROOT/pages/constraints-and-score/score-calcul…
b9274bb 
…ation.adoc

Co-authored-by: Christopher Chianelli <christopher@timefold.ai>
triceo
triceo approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@triceo triceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well-chosen examples, I like this!

@triceo triceo linked an issue Feb 4, 2025 that may be closed by this pull request
Provide better explanation and examples to consecutive collectors #1310
Closed
Christopher-Chianelli
Christopher-Chianelli approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@Christopher-Chianelli Christopher-Chianelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when the minor python formatting is fixed.

docs/src/modules/ROOT/pages/constraints-and-score/score-calculation.adoc Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 4, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@triceo @Christopher-Chianelli
Update docs/src/modules/ROOT/pages/constraints-and-score/score-calcul…
29d24cb 
…ation.adoc

Co-authored-by: Christopher Chianelli <christopher@timefold.ai>
@triceo triceo merged commit bc77f8e into TimefoldAI:main Feb 5, 2025
22 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@triceo triceo triceo approved these changes

@Christopher-Chianelli Christopher-Chianelli Christopher-Chianelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide better explanation and examples to consecutive collectors
3 participants
@TomCools @triceo @Christopher-Chianelli