Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: replace JDK 20 with 21 #329

Merged
merged 1 commit into from
Oct 12, 2023
Merged

ci: replace JDK 20 with 21 #329

merged 1 commit into from
Oct 12, 2023

Conversation

triceo
Copy link
Contributor

@triceo triceo commented Oct 11, 2023 •
edited
Loading

JDK 21 build status:
adoptium/temurin#8

@triceo triceo requested a review from rsynek October 11, 2023 10:18
rsynek
rsynek approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@rsynek rsynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we wait with merging until they finish the release phase for Windows and Mac?

@triceo
Copy link
Contributor Author

triceo commented Oct 12, 2023

The issue seems outdated. Clearly Windows and Mac are published, because our CI works.

@triceo triceo merged commit bfbfd5a into TimefoldAI:main Oct 12, 2023
9 checks passed
@triceo triceo deleted the twenty-one branch October 12, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsynek rsynek rsynek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@triceo @rsynek