Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ensuring the spent termination property is read in the Quarkus environment #600

Merged
merged 3 commits into from
Jan 31, 2024
Merged

fix: Ensuring the spent termination property is read in the Quarkus environment #600

merged 3 commits into from
Jan 31, 2024

Conversation

zepfred
Copy link
Contributor

@zepfred zepfred commented Jan 30, 2024

This pull request fixes a bug in the Quarkus Benchmark extension that was causing the termination properties to be ignored.

@zepfred zepfred linked an issue Jan 30, 2024 that may be closed by this pull request
Time spent termination quarkus property ignored in Quarkus environment? #269
Closed
@zepfred zepfred requested a review from triceo January 30, 2024 18:11
triceo
triceo approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@triceo triceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I wouldn't check for the entire long message of the exception, just the relevant part.

But LGTM! Please double-check if we perhaps have the same issue in Spring.

@zepfred
Copy link
Contributor Author

zepfred commented Jan 31, 2024

Maybe I wouldn't check for the entire long message of the exception, just the relevant part.

But LGTM! Please double-check if we perhaps have the same issue in Spring.

The Spring Boot module is not affected by this bug.

@triceo
Copy link
Contributor

triceo commented Jan 31, 2024

Formatting is broken.

@triceo triceo merged commit 693e321 into TimefoldAI:main Jan 31, 2024
10 checks passed
@zepfred zepfred deleted the termination-ignored-fix#269 branch March 27, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@triceo triceo triceo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Time spent termination quarkus property ignored in Quarkus environment?
2 participants
@zepfred @triceo