Continue to compact batches that can use it #277
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the cases in which a trace may introduce phantom batches for the purposes of spurring compaction. Previously, this would not happen if there was just one non-empty batch. However, this was defective if that one batch had times that would collapse if only logical compaction were to be applied.
It is hard to know whether logical compaction will help generally without doing the work, but we can introduce a cheap surrogate which is that as long as the
since
bound for the batch is not beyond theupper
bound for the batch, then there is still some potential for compaction ifsince
were to advance.We don't know that anything good will happen in general, but for totally ordered times this is a sufficient test (once
since
is beyondupper
, no further logical compaction will occur).