Update to latest Timely #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiguru
force-pushed
the
update_timely
branch
from
300c403
to
7957bf6
Compare
Bring in changes related to abomination and reference-counted addresses. Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
antiguru
force-pushed
the
update_timely
branch
from
7957bf6
to
9a43417
Compare
| @@ -159,7 +159,6 @@ mod val_batch { | |||
| /// | |||
| /// The `L` parameter captures how the updates should be laid out, and `C` determines which | |||
| /// merge batcher to select. | |||
| #[derive(Abomonation)] | |||
There was a problem hiding this comment.
Does this need a #[derive(Serialize, Deserialize)]? I don't know, and maybe we wont until we start to use it? :)
There was a problem hiding this comment.
We cannot easily. Serde requires the GAT to be serialize/deserialize unless we tell it otherwise.
There was a problem hiding this comment.
Gotcha. And .. no particular reason to want to serialize / deserialize these, outside perhaps of interest in some DD-based persistence? I guess I forget why the derive(Abomonation) was there in the first place, and perhaps there was no reason anymore?
| @@ -720,7 +719,6 @@ mod key_batch { | |||
| /// | |||
| /// The `L` parameter captures how the updates should be laid out, and `C` determines which | |||
| /// merge batcher to select. | |||
| #[derive(Abomonation)] | |||
There was a problem hiding this comment.
Same as above; removing a derived Abomonation without introducing Serialize, Deserialize. Idk the consequences.
| @@ -250,8 +250,7 @@ mod val_batch { | |||
| /// | |||
| /// The `L` parameter captures how the updates should be laid out, and `C` determines which | |||
| /// merge batcher to select. | |||
| #[derive(Abomonation)] | |||
| pub struct RhhValBatch<L: Layout> | |||
| pub struct RhhValBatch<L: Layout> | |||
frankmcsherry
approved these changes
Sep 9, 2024
Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
antiguru
added a commit
to MaterializeInc/differential-dataflow
that referenced
this pull request
Sep 9, 2024
Update to latest Timely (TimelyDataflow#519)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring in changes related to abomination and reference-counted addresses.
Signed-off-by: Moritz Hoffmann antiguru@gmail.com