Skip to content

Conversation

@TimilsinaBimal
Copy link
Owner

No description provided.

@vercel
Copy link

vercel bot commented Dec 20, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
watchly Ready Ready Preview, Comment Dec 20, 2025 6:15pm

@gemini-code-assist
Copy link

Summary of Changes

Hello @TimilsinaBimal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the library item processing logic to recognize and handle items identified by TMDB IDs. This ensures that items using The Movie Database identifiers are properly included and managed within the system, improving compatibility and data handling for a wider range of media entries.

Highlights

  • TMDB ID Support: The get_library_items function in app/services/stremio/library.py has been updated to correctly process item IDs that are prefixed with "tmdb:", alongside the existing support for IMDb IDs ("tt:").

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@TimilsinaBimal TimilsinaBimal linked an issue Dec 20, 2025 that may be closed by this pull request
@TimilsinaBimal TimilsinaBimal merged commit 13b0d5a into main Dec 20, 2025
4 checks passed
@TimilsinaBimal TimilsinaBimal deleted the fix/tmdb-catalogs branch December 20, 2025 18:16
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for TMDB IDs (prefixed with tmdb:) in the Stremio library service, which previously only supported IMDb IDs (prefixed with tt). The change is correct and necessary for broader compatibility. I have one suggestion to make the implementation more concise and Pythonic.

Comment on lines +77 to +78
if not item_id.startswith("tt") and not item_id.startswith("tmdb:"):
# either imdb id or tmdb id should be there.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better readability and conciseness, you can provide a tuple of prefixes to the startswith() method. This simplifies the conditional check.

Additionally, the comment on the following line becomes redundant as the refactored code is self-explanatory.

Suggested change
if not item_id.startswith("tt") and not item_id.startswith("tmdb:"):
# either imdb id or tmdb id should be there.
if not item_id.startswith(("tt", "tmdb:")):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Addon not appearing on Stremio

2 participants