feat: add option to configure top_posters for poster rating #94
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary of ChangesHello @TimilsinaBimal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the flexibility and user experience for integrating external poster rating services. It refactors the backend to support multiple providers, introduces a dedicated API endpoint for validating API keys, and updates the user settings to accommodate provider-specific configurations. On the frontend, users now have a more intuitive interface to select their preferred poster rating service and validate their API keys, ensuring a smoother setup process. A robust migration mechanism is also in place to seamlessly transition existing users from the old single-key setup to the new, more versatile configuration. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new feature for integrating external poster rating providers (RPDB and Top Posters) into the application. It adds new API endpoints for validating provider API keys, creates dedicated service classes for each provider to handle API interactions, and updates user settings to store provider configuration instead of a single RPDB key. The changes include a migration strategy for existing rpdb_key settings to the new poster_rating object format, with encryption and decryption handled in the token store. The frontend UI has been updated to provide a dropdown for selecting a poster rating provider, an API key input field with a visibility toggle and client-side validation, and dynamic help text. Review comments highlighted issues such as the hardcoded fallback parameter in the RPDB service, the hardcoded imdb provider in the poster URL resolution logic which could lead to incorrect lookups for TMDB IDs, and the broad exception handling in the API key validation endpoint. Additionally, suggestions were made to gracefully handle failed API key decryption by setting the key to None, to use an Enum for provider validation in the Pydantic model for better type safety, and to remove redundant error messages during client-side API key validation.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
… improve error handling in API key validation
…ly into feat/rating-posters
* fix: get started button is not functional * fix: get started button is not functional * chore: bump version to 1.0.1 (#38) * feat: Add recency preference and genre diversification to recommendation logic (#44) * feat: Enhance TMDBService with trending and top-rated content retrieval * feat: Add recency preference and genre diversification to recommendation logic * feat: Refactor TMDBService usage to support language preference across services * feat: Refactor library item fetching and caching for improved performance and consistency * feat: Implement caching for language retrieval and refactor auth key encryption * feat: Add middleware for Redis call tracking and enhance token store with call counting * chore: bump version to v1.1.0 * feat: Enhance Redis client management and implement rate limiting for token requests * feat: Refactor catalog fetching and update migration task handling * chore: bump version to v1.1.2 * feat: add option to configure top_posters for poster rating (#94) * feat: add option to configure top_posters for poster rating * feat: implement poster rating API key validation and frontend integration * feat: add display_at_home and shuffle options to Stremio identity fetch * refactor: rename get_poster methods to get_poster_url for clarity and improve error handling in API key validation * chore: bump version to v1.6.2-rc.1 * feat: add User-Agent header to API requests in TopPostersService * feat: update PosterRatingConfig to use Literal for provider type validation * refactor: rename get_poster method to get_poster_url for consistency in PosterRatingsFactory * refactor: update constants for top picks and adjust scoring logic to enhance recommendation quality * fix: priotrize reacted items when preparing library even if they are not watched * chore: bump version to v1.6.2-rc.2 * chore: bump version to v1.7.0
No description provided.