Fix ordering arranging handler for >65536 packets #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The expected index is a u16 at the protocol level, but the arranging implementation for orderingstream does not take this into account. This caused sending over 2**16 ordered packets to simply default to the `None` case and get ignored. This patch solves that issue.
Codecov Report
@@ Coverage Diff @@
## master #229 +/- ##
==========================================
+ Coverage 97.37% 97.54% +0.16%
==========================================
Files 25 25
Lines 2440 2486 +46
==========================================
+ Hits 2376 2425 +49
+ Misses 64 61 -3
Continue to review full report at Codecov.
|
jstnlef
approved these changes
Sep 1, 2019
kstrafe
force-pushed
the
ordered-fail-2
branch
from
dd150cb
to
ce03a18
Compare
Previously we would only store packets with indices higher than the expected index, this is obviously not going to give us good results when we receive packets 0..100 while we are currently expecting index 65500. What this patch does is that it stores all incoming packets with the condition: expected < index < expected + u16::max/2 With wrapping add this becomes slightly more complex but the gist is the same.
jstnlef
added a commit
to jstnlef/laminar
that referenced
this pull request
Oct 12, 2019
Fix ordering arranging handler for >65536 packets
jstnlef
added a commit
that referenced
this pull request
Oct 12, 2019
Fix ordering arranging handler for >65536 packets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The arranging handler would not reset the value of the expecting index back to 0 which caused the case of having over 2**16 packets to simply be ignored.
Note: This is #227 but for some reason it didn't track my commits after merging #228, so that one got closed and this one opened. (Apparently had upstreamed to master...)