Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sequenced loop u16 #231

Merged
merged 2 commits into from
Sep 2, 2019
Merged

Sequenced loop u16 #231

merged 2 commits into from
Sep 2, 2019

Conversation

kstrafe
Copy link
Contributor

@kstrafe kstrafe commented Sep 1, 2019 

sequencing: Loop the indexing method

Sending over 65536 packets would previously just saturate the top_index
which caused it to not accept any more packets. This patch shortens the
sequence acceptance by half but always loops around the max u16 value.

This means that at top_index = 0, all sequenced packets 0-32768 are
accepted, while at top_index = 50000, all sequenced packets 50000-65535
and 0-17233 will be accepted.

@codecov
Copy link

codecov bot commented Sep 1, 2019 •
edited
Loading

Codecov Report

Merging #231 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #231   +/-   ##
=======================================
  Coverage   97.75%   97.75%           
=======================================
  Files          25       25           
  Lines        2891     2891           
=======================================
  Hits         2826     2826           
  Misses         65       65

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d93fc01...6c1c91e. Read the comment docs.

@kstrafe
sequencing: Loop the indexing method
6c1c91e 
Sending over 65536 packets would previously just saturate the top_index
which caused it to not accept any more packets. This patch shortens the
sequence acceptance by half but always loops around the max u16 value.

This means that at top_index = 0, all sequenced packets 0-32768 are
accepted, while at top_index = 50000, all sequenced packets 50000-65535
and 0-17233 will be accepted.
@TimonPost TimonPost merged commit a7baf72 into TimonPost:master Sep 2, 2019
jstnlef pushed a commit to jstnlef/laminar that referenced this pull request Oct 12, 2019
@kstrafe @jstnlef
Sequenced loop u16 (TimonPost#231)
f310436 
Sending over 65536 packets would previously just saturate the top_index
which caused it to not accept any more packets. This patch shortens the
sequence acceptance by half but always loops around the max u16 value.

This means that at top_index = 0, all sequenced packets 0-32768 are
accepted, while at top_index = 50000, all sequenced packets 50000-65535
and 0-17233 will be accepted.
jstnlef pushed a commit that referenced this pull request Oct 12, 2019
@kstrafe @jstnlef
Sequenced loop u16 (#231)
7808730 
Sending over 65536 packets would previously just saturate the top_index
which caused it to not accept any more packets. This patch shortens the
sequence acceptance by half but always loops around the max u16 value.

This means that at top_index = 0, all sequenced packets 0-32768 are
accepted, while at top_index = 50000, all sequenced packets 50000-65535
and 0-17233 will be accepted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimonPost TimonPost TimonPost approved these changes

@jstnlef jstnlef jstnlef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kstrafe @jstnlef @TimonPost