Disconnect the connection after sending N un-acked packets #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstrafe
force-pushed
the
sequenced-pathological-disconnect
branch
2 times, most recently
from
b861dc0
to
35eb8de
Compare
jstnlef
approved these changes
Sep 2, 2019
|
@jstnlef What do you propose? This value is basically a "disable" value as it stands. |
kstrafe
force-pushed
the
sequenced-pathological-disconnect
branch
from
35eb8de
to
d7b1174
Compare
|
What about 512? Less than 20 seconds at 30 Hz send rate. Let's it be generous without being too soon. |
kstrafe
force-pushed
the
sequenced-pathological-disconnect
branch
from
d7b1174
to
365c16b
Compare
|
Sounds good |
The connection is disconnected if we have N packets-in-flight simultaneously. Under normal usage we expect packets to be acked regularly so that our packets-in-flight size is relatively small.
|
Had to abort the build (sorry -- the build agent got stuck and had to be restarted). I think you have to push another commit to restart a build. |
TimonPost
approved these changes
Sep 4, 2019
Codecov Report
@@ Coverage Diff @@
## master #234 +/- ##
==========================================
- Coverage 97.57% 97.53% -0.04%
==========================================
Files 25 25
Lines 2554 2597 +43
==========================================
+ Hits 2492 2533 +41
- Misses 62 64 +2
Continue to review full report at Codecov.
|
|
Codecov is just complaining about panics not being triggered in a test. |
jstnlef
pushed a commit
to jstnlef/laminar
that referenced
this pull request
Oct 12, 2019
…#234) The connection is disconnected if we have N packets-in-flight simultaneously. Under normal usage we expect packets to be acked regularly so that our packets-in-flight size is relatively small.
jstnlef
pushed a commit
that referenced
this pull request
Oct 12, 2019
The connection is disconnected if we have N packets-in-flight simultaneously. Under normal usage we expect packets to be acked regularly so that our packets-in-flight size is relatively small.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The connection is disconnected if we have N packets-in-flight
simultaneously. Under normal usage we expect packets to be acked
regularly so that our packets-in-flight size is relatively small.