Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing symbol from the shared library #32

Closed
dbermond opened this issue Dec 18, 2020 · 2 comments · Fixed by #33
Closed

Missing symbol from the shared library #32

dbermond opened this issue Dec 18, 2020 · 2 comments · Fixed by #33
Milestone

Comments

@dbermond
Copy link
Contributor

The symbol WebRtcIlbcfix_InitDecode is missed from the shared library. The following command produces no output:

$ nm -D libilbc.so | grep 'WebRtcIlbcfix_InitDecode'

As a result, applications that uses this function and tries to link against libilbc.so fails to build. For example, FFmpeg is showing me this error:

/usr/bin/ld: /tmp/ffconf.mxjpOf0E/test.o: in function `check_WebRtcIlbcfix_InitDecode':
test.c:(.text+0x3): undefined reference to `WebRtcIlbcfix_InitDecode'
collect2: error: ld returned 1 exit status
ERROR: libilbc not found

This can be fixed by the following modification, but I'm not sure if it would be desirable for the project. Probably there could be a better solution.

--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -44,7 +44,6 @@ if(NOT CMAKE_BUILD_TYPE)
     set(CMAKE_BUILD_TYPE Release)
 endif()
 
-set(CMAKE_C_VISIBILITY_PRESET hidden)
 set(CMAKE_CXX_VISIBILITY_PRESET hidden)
 set(CMAKE_VISIBILITY_INLINES_HIDDEN 1)
 
@TimothyGu
Copy link
Owner

Darn, I fixed this for init_encode but not init_decode…

TimothyGu added a commit that referenced this issue Dec 19, 2020
TimothyGu added a commit that referenced this issue Dec 19, 2020
Also fix [full ci] for new PRs.

Fixes: #32
@TimothyGu TimothyGu added this to the Version 3.0.3 milestone Dec 19, 2020
@dbermond
Copy link
Contributor Author

Thank you for fixing this! Working fine now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants