index: allow #fragments in PR URLs

Also check tightened PR_RE against pathname
TimothyGu · Jan 29, 2017 · f30ffde · f30ffde
1 parent af66e3f
commit f30ffde
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/index.js b/index.js
@@ -1,11 +1,11 @@
 'use strict'
 
-const PR_RE = /\/nodejs\/([^\/]+)\/pull\/([^\/]+)\/?$/
+const PR_RE = /^\/nodejs\/([^\/]+)\/pull\/([^\/]+)\/?$/
 
 const b = chrome.extension.getBackgroundPage()
 chrome.tabs.onUpdated.addListener((tabId, changeInfo, tab) => {
   if (changeInfo.url === undefined) return
-  if (PR_RE.test(changeInfo.url)) {
+  if (PR_RE.test(new URL(changeInfo.url).pathname)) {
     chrome.browserAction.enable()
     chrome.browserAction.setIcon({
       path: 'icon_good.png'

diff --git a/review.js b/review.js
@@ -6,7 +6,7 @@
   , REJECTED: 'REJECTED'
   }
 
-  const PR_RE = /\/nodejs\/([^\/]+)\/pull\/([^\/]+)\/?$/
+  const PR_RE = /^\/nodejs\/([^\/]+)\/pull\/([^\/]+)\/?$/
 
   const { prUrl, repo } = getPR()
   if (!prUrl) {