[WIP] Usage collection es clients #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TinaHeiligers
pushed a commit
that referenced
this pull request
Oct 11, 2024
<Actions>
<action
id="ad27da7f660d61c82c61599e0e6945827ced1590f4bf36a5f74db07e99c04215">
<h3>deps: Bump ironbank version</h3>
<details
id="99cabf4d5a2b44b2d93b4c18590b8ccd5df3002e8d9d506c038c9011e8e93734">
<summary>deps(ironbank): Bump ubi version to 9.4</summary>
<p>change detected:
	* key "$.args.BASE_TAG" updated
from "'9.4'" to "\"9.4\"", in file
"src/dev/build/tasks/os_packages/docker_generator/templates/ironbank/hardening_manifest.yaml"</p>
</details>
<a
href="https://github.com/elastic/kibana/actions/runs/11287176047">GitHub
Action workflow link</a>
</action>
</Actions>
---
<table>
<tr>
<td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
</td>
<td>
<p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
</p>
<details><summary>Options:</summary>
<br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
<ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
</ul>
<p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
</p>
</details>
</td>
</tr>
</table>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
elasticmachine
pushed a commit
that referenced
this pull request
Nov 21, 2024
<Actions>
<action
id="ad27da7f660d61c82c61599e0e6945827ced1590f4bf36a5f74db07e99c04215">
<h3>deps: Bump ironbank version</h3>
<details
id="21fe544f0edf8039d0165187f8204a62da22d72e50fa57839d823beb83c0df2e">
<summary>deps(ironbank): Bump ubi version to 9.5</summary>
<p>changed lines [7] of file
"/tmp/updatecli/github/elastic/kibana/src/dev/build/tasks/os_packages/docker_generator/templates/ironbank/Dockerfile"</p>
</details>
<details
id="99cabf4d5a2b44b2d93b4c18590b8ccd5df3002e8d9d506c038c9011e8e93734">
<summary>deps(ironbank): Bump ubi version to 9.5</summary>
<p>change detected:
	* key "$.args.BASE_TAG" updated
from "\"9.4\"" to "\"9.5\"", in file
"src/dev/build/tasks/os_packages/docker_generator/templates/ironbank/hardening_manifest.yaml"</p>
</details>
<a
href="https://github.com/elastic/kibana/actions/runs/11927677417">GitHub
Action workflow link</a>
</action>
</Actions>
---
<table>
<tr>
<td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
</td>
<td>
<p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
</p>
<details><summary>Options:</summary>
<br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
<ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
</ul>
<p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
</p>
</details>
</td>
</tr>
</table>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Handles step 3 in elastic#74840 (comment).
As part of migrating over to the new elasticsearch client, we provided the new client as an additional parameter to the
fetchmethod in collectors and pass the client down as an additional collection config parameter.Using the new client forces plugins to provide the old client as well, which is not ideal.
This work refactors the way in which we provide the clients from individual arguments to an object, allowing plugins to select the client they wish to use.
This is a breaking change and requires refactoring collectors in all the plugins that currently use
callCluster.Checklist
Delete any items that are not applicable to this PR.
For maintainers