Skip to content

Conversation

tinder-maxwellelliott
Copy link
Collaborator

This reverts commit 68e99f1.

Fixes #147

@arie-stripe
Copy link

Thanks for addressing this so quickly! 🙂

@tinder-maxwellelliott
Copy link
Collaborator Author

Thanks for addressing this so quickly! 🙂

This worked for you with local testing?

@arie-stripe
Copy link

arie-stripe commented Sep 23, 2022

@tinder-maxwellelliott yup!

No warning message, but I'm fine with that. Just thought I'd point it out in case that's what you wanted.

❱❱❱ git clone https://github.com/Tinder/bazel-diff.git
Cloning into 'bazel-diff'...
remote: Enumerating objects: 1517, done.
remote: Counting objects: 100% (540/540), done.
remote: Compressing objects: 100% (222/222), done.
remote: Total 1517 (delta 297), reused 416 (delta 248), pack-reused 977
Receiving objects: 100% (1517/1517), 571.23 KiB | 2.30 MiB/s, done.
Resolving deltas: 100% (568/568), done.
❱❱❱ cd bazel-diff
❱❱❱ git checkout maxwelle/revert_cyclic_fix
branch 'maxwelle/revert_cyclic_fix' set up to track 'origin/maxwelle/revert_cyclic_fix'.
Switched to a new branch 'maxwelle/revert_cyclic_fix'
❱❱❱ bazel build //cli:bazel-diff_deploy.jar
Starting local Bazel server and connecting to it...
INFO: Analyzed target //cli:bazel-diff_deploy.jar (41 packages loaded, 990 targets configured).
INFO: Found 1 target...
INFO: From KotlinCompile //cli:cli-lib { kt: 31, java: 0, srcjars: 0 } for darwin:
warning: '-Xuse-experimental' is deprecated and will be removed in a future releaseTarget //cli:bazel-diff_deploy.jar up-to-date:
  bazel-bin/cli/bazel-diff_deploy.jar
INFO: Elapsed time: 66.040s, Critical Path: 40.35s
INFO: 49 processes: 12 internal, 31 darwin-sandbox, 6 worker.
INFO: Build completed successfully, 49 total actions
❱❱❱ cd ../huge-monorepo
❱❱❱ java -jar ../bazel-diff/bazel-bin/cli/bazel-diff_deploy.jar generate-hashes -b $(which bazel) -w $PWD hashes.json
Loading: 0 packages loaded
Loading: 0 packages loaded

Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded

Loading: 0 packages loaded
❱❱❱ echo $?
0
❱❱❱ wc -l hashes.json
<huge_number> hashes.json

@arie-stripe
Copy link

@tinder-maxwellelliott sorry if I'm being a bother, but do you know when this might get merged/released? I can always fork but I'd prefer not to if you plan to cut a release soon 🙂

Thanks again!

@tinder-maxwellelliott tinder-maxwellelliott merged commit cc343ce into master Sep 26, 2022
@tinder-maxwellelliott tinder-maxwellelliott deleted the maxwelle/revert_cyclic_fix branch September 26, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Blocked by transitive dep causing CircularDependencyException, while Bazel builds fine

2 participants