Skip to content

fix: Duration Reporting #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2023
Merged

fix: Duration Reporting #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions cli/src/main/kotlin/com/bazel_diff/bazel/BazelClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,9 @@ class BazelClient : KoinComponent {
private val queryService: BazelQueryService by inject()

suspend fun queryAllTargets(): List<BazelTarget> {
var calendar = Calendar.getInstance()
val queryEpoch = calendar.getTimeInMillis()
val queryEpoch = Calendar.getInstance().getTimeInMillis()
val targets = queryService.query("'//external:all-targets' + '//...:all-targets'")
val queryDuration = calendar.getTimeInMillis() - queryEpoch
val queryDuration = Calendar.getInstance().getTimeInMillis() - queryEpoch
logger.i { "All targets queried in $queryDuration" }
return targets.mapNotNull { target: Build.Target ->
when (target.type) {
Expand All @@ -35,10 +34,9 @@ class BazelClient : KoinComponent {
}

suspend fun queryAllSourcefileTargets(): List<Build.Target> {
var calendar = Calendar.getInstance()
val queryEpoch = calendar.getTimeInMillis()
val queryEpoch = Calendar.getInstance().getTimeInMillis()
val targets = queryService.query("kind('source file', //...:all-targets)")
val queryDuration = calendar.getTimeInMillis() - queryEpoch
val queryDuration = Calendar.getInstance().getTimeInMillis() - queryEpoch
logger.i { "All source files queried in $queryDuration" }

return targets
Expand Down
5 changes: 2 additions & 3 deletions cli/src/main/kotlin/com/bazel_diff/hash/BuildGraphHasher.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,9 @@ class BuildGraphHasher(private val bazelClient: BazelClient) : KoinComponent {
* Querying targets and source hashing is done in parallel
*/
val sourceDigestsFuture = async(Dispatchers.IO) {
var calendar = Calendar.getInstance()
val sourceHashDurationEpoch = calendar.getTimeInMillis()
val sourceHashDurationEpoch = Calendar.getInstance().getTimeInMillis()
val sourceFileTargets = hashSourcefiles(sourceTargets)
val sourceHashDuration = calendar.getTimeInMillis() - sourceHashDurationEpoch
val sourceHashDuration = Calendar.getInstance().getTimeInMillis() - sourceHashDurationEpoch
logger.i { "Source file hashes calculated in $sourceHashDuration" }
sourceFileTargets
}
Expand Down
5 changes: 2 additions & 3 deletions cli/src/main/kotlin/com/bazel_diff/interactor/GenerateHashesInteractor.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@ class GenerateHashesInteractor : KoinComponent {

fun execute(seedFilepaths: File?, outputPath: File?): Boolean {
return try {
var calendar = Calendar.getInstance()
val epoch = calendar.getTimeInMillis()
val epoch = Calendar.getInstance().getTimeInMillis()
var seedFilepathsSet: Set<Path> = when {
seedFilepaths != null -> {
BufferedReader(FileReader(seedFilepaths)).use {
Expand All @@ -39,7 +38,7 @@ class GenerateHashesInteractor : KoinComponent {
}.use {
it.write(gson.toJson(hashes))
}
val duration = calendar.getTimeInMillis() - epoch;
val duration = Calendar.getInstance().getTimeInMillis() - epoch;
logger.i { "generate-hashes finished in $duration" }
true
} catch (e: Exception) {
Expand Down