Skip to content

Conversation

honnix
Copy link
Contributor

@honnix honnix commented Oct 22, 2024

Closes #236

This PR adds a new flag --[no--]excludeExternalTargets that aims to support --noenable_workspace Bazel flag. This flag defaults to false so should be backward compatible.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Collaborator

@tinder-maxwellelliott tinder-maxwellelliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@tinder-maxwellelliott tinder-maxwellelliott merged commit bd71bc5 into Tinder:master Oct 22, 2024
8 checks passed
@meteorcloudy
Copy link

Thanks for the fix, can you make a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bazel-diff breaks with --noenable_workspace

4 participants