fix: Fix cquery targets filtering #251
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #218
Convert
Build.Target
intoBazelTarget
first before applying the filtering. Doing so will make it easy to filter onname
.Note that e2e tests need to be fixed. Before I go fix those, I wanted to make sure this solution looks good. @tinder-maxwellelliott Please let me know what you think. Thanks.Or maybe a more basic question: is this by design that
cquery
discarding source and generated targets, whichquery
doesn't do?