Skip to content

Conversation

blockjon-dd
Copy link
Contributor

@blockjon-dd blockjon-dd commented Jun 30, 2025

I want to make sure all of the rules_go managed "external" Go libraries (eventually represented as Bazel "repos") are considered when hashing occurs.

Without this PR, it seems that I would need to list them all out in a comma separated string param using --fineGrainedHashExternalRepos, which risks exceeding the bash arg length. Because in rules_go, each go dependency becomes an individually addressable bazel repo, the argument length would explode because I have hundreds of Go libraries listed in my go.mod which are seen as hundreds of Bazel repos due to MODULE.bazel notation that ultimately looks like this:

use_repo(
    go_deps,
    "cc_mvdan_gofumpt",
    "com_github_adrg_strutil",
    ...

Right there, that's two separate Bazel repos.. but in reality, there will be hundreds of them.

For this reason, I'm proposing this PR in which the list of repos may be defined in a file, which avoids any glitches with the bash arg length limit.

@CLAassistant
Copy link

CLAassistant commented Jun 30, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@tinder-maxwellelliott tinder-maxwellelliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@tinder-maxwellelliott tinder-maxwellelliott merged commit 82ac6e4 into Tinder:master Jul 1, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants