Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first implementation of external modifications #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rugk
Copy link
Member

@rugk rugk commented Jun 6, 2019

No description provided.

@todo
Copy link

todo bot commented Jul 17, 2019

. UNUSED OPTION

* @param {string} option string ob object ID // TODO. UNUSED OPTION
* @param {Object} optionValue the value to set
* @param {HTMLElement} elOption where to apply feature
* @returns {void}


This comment was generated by todo based on a TODO comment in 2bc739f in #10. cc @TinyWebEx.

@todo
Copy link

todo bot commented Jul 17, 2019

refactor this if to include in getOptionIdFromElement

} // TODO: refactor this if to include in getOptionIdFromElement
return setManagedOption(option, optionGroup, elOption).catch((error) => {
/* only log warning as that is expected when no manifest file is found */


This comment was generated by todo based on a TODO comment in 2bc739f in #10. cc @TinyWebEx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant