Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add total support for I18N and for custom first weekday selection #4

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

giraldezjorge
Copy link

Hi,
At first time, congratulations for this amazing component. I tried to make a similar component but you made it better than me xD

I did two commits to improve your calendar component:

  • Add total support for I18N, including month names. Set "en" as default language. In case you don't add the customI18n object, or any property is not included, a default english value will be used.
  • Allow to select the first weekday for calendar (month days and week names). For example in Spain the first weekday is Monday. With these changes you can select any day as first weekday.

I hope you like these two commits.

Regards

@giraldezjorge
Copy link
Author

Oh sorry, travis failed because I forget to adapt the tests.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.3%) to 89.12% when pulling 342eb9b on giraldezjorge:master into acd6b0b on Tinysymphony:master.

@giraldezjorge
Copy link
Author

I fixed tests. They passed now

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.6%) to 88.813% when pulling 527491a on giraldezjorge:master into acd6b0b on Tinysymphony:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.5%) to 88.939% when pulling 9297914 on giraldezjorge:master into acd6b0b on Tinysymphony:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.7%) to 85.745% when pulling 2ed1bf8 on giraldezjorge:master into acd6b0b on Tinysymphony:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants