Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for KSP where possible: hilt & room #81

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

IuliaSTANA
Copy link
Contributor

Use KSP wherever possible in the core

Copy link
Contributor

@dzolnai dzolnai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I quickly scrolled throught the libraries, but it seems that you don't need kapt anymore, and the plugin can be removed?

@IuliaSTANA
Copy link
Contributor Author

I quickly scrolled throught the libraries, but it seems that you don't need kapt anymore, and the plugin can be removed?

The sample app is using data binding and so does the the TIQR. I'm keeping it for that.
But, I think I can safely remove it from the core module alone.
I will do that when I refactor the core so the eduid app can work with core module i.s.o. data module

@IuliaSTANA IuliaSTANA merged commit 19188bf into develop Dec 7, 2023
1 check passed
@IuliaSTANA IuliaSTANA deleted the bugfix/migrate-to-ksp branch December 7, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants