Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Some grants don't work with database roles #163

Merged
merged 6 commits into from
Nov 25, 2024

Conversation

teej
Copy link
Collaborator

@teej teej commented Nov 25, 2024

No description provided.

@teej teej had a problem deploying to snowflake-gcp-standard November 25, 2024 22:22 — with GitHub Actions Failure
@teej teej had a problem deploying to snowflake-aws-standard November 25, 2024 22:22 — with GitHub Actions Failure
@teej teej had a problem deploying to snowflake-aws-enterprise November 25, 2024 22:22 — with GitHub Actions Failure
@teej teej had a problem deploying to snowflake-aws-business-critical November 25, 2024 22:22 — with GitHub Actions Failure
@teej teej had a problem deploying to snowflake-azure-standard November 25, 2024 22:22 — with GitHub Actions Failure
@teej teej had a problem deploying to snowflake-gcp-standard November 25, 2024 22:34 — with GitHub Actions Failure
@teej teej had a problem deploying to snowflake-aws-standard November 25, 2024 22:34 — with GitHub Actions Failure
@teej teej had a problem deploying to snowflake-aws-enterprise November 25, 2024 22:34 — with GitHub Actions Failure
@teej teej had a problem deploying to snowflake-aws-business-critical November 25, 2024 22:34 — with GitHub Actions Failure
@teej teej had a problem deploying to snowflake-azure-standard November 25, 2024 22:34 — with GitHub Actions Failure
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 94.87179% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
titan/resources/grant.py 85.18% 4 Missing ⚠️
Files with missing lines Coverage Δ
...s/integration/data_provider/test_fetch_resource.py 96.25% <100.00%> (+0.14%) ⬆️
tests/integration/test_lifecycle.py 82.78% <100.00%> (+2.23%) ⬆️
tests/integration/test_resources.py 100.00% <ø> (ø)
tests/test_grant.py 100.00% <100.00%> (ø)
titan/data_provider.py 82.63% <100.00%> (+0.60%) ⬆️
titan/lifecycle.py 72.00% <ø> (ø)
titan/resources/grant.py 92.90% <85.18%> (-0.71%) ⬇️

... and 1 file with indirect coverage changes

@teej teej had a problem deploying to snowflake-gcp-standard November 25, 2024 22:46 — with GitHub Actions Failure
@teej teej had a problem deploying to snowflake-aws-standard November 25, 2024 22:46 — with GitHub Actions Failure
@teej teej had a problem deploying to snowflake-aws-enterprise November 25, 2024 22:46 — with GitHub Actions Failure
@teej teej had a problem deploying to snowflake-aws-business-critical November 25, 2024 22:46 — with GitHub Actions Failure
@teej teej had a problem deploying to snowflake-azure-standard November 25, 2024 22:46 — with GitHub Actions Failure
@teej teej had a problem deploying to snowflake-gcp-standard November 25, 2024 22:50 — with GitHub Actions Failure
@teej teej had a problem deploying to snowflake-aws-standard November 25, 2024 22:50 — with GitHub Actions Failure
@teej teej had a problem deploying to snowflake-aws-enterprise November 25, 2024 22:51 — with GitHub Actions Failure
@teej teej had a problem deploying to snowflake-aws-business-critical November 25, 2024 22:51 — with GitHub Actions Failure
@teej teej had a problem deploying to snowflake-azure-standard November 25, 2024 22:51 — with GitHub Actions Failure
@teej teej temporarily deployed to snowflake-gcp-standard November 25, 2024 22:54 — with GitHub Actions Inactive
@teej teej temporarily deployed to snowflake-aws-standard November 25, 2024 22:54 — with GitHub Actions Inactive
@teej teej temporarily deployed to snowflake-aws-enterprise November 25, 2024 22:54 — with GitHub Actions Inactive
@teej teej temporarily deployed to snowflake-aws-business-critical November 25, 2024 22:54 — with GitHub Actions Inactive
@teej teej temporarily deployed to snowflake-azure-standard November 25, 2024 22:54 — with GitHub Actions Inactive
@teej teej temporarily deployed to snowflake-gcp-standard November 25, 2024 22:58 — with GitHub Actions Inactive
@teej teej temporarily deployed to snowflake-aws-standard November 25, 2024 22:58 — with GitHub Actions Inactive
@teej teej temporarily deployed to snowflake-aws-enterprise November 25, 2024 22:58 — with GitHub Actions Inactive
@teej teej temporarily deployed to snowflake-aws-business-critical November 25, 2024 22:58 — with GitHub Actions Inactive
@teej teej temporarily deployed to snowflake-azure-standard November 25, 2024 22:58 — with GitHub Actions Inactive
@teej teej merged commit 8968b56 into main Nov 25, 2024
9 checks passed
@teej teej deleted the bugfix/database-role-fqn branch November 25, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant