Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS2 porting #254

Merged
merged 1 commit into from
Jun 11, 2021
Merged

ROS2 porting #254

merged 1 commit into from
Jun 11, 2021

Conversation

grischi
Copy link
Collaborator

@grischi grischi commented Jun 11, 2021

Please note my comments on this ROS2 branch in README.md. It gives an overview of completeness, amongst other infos.

@TixiaoShan
Copy link
Owner

@grischi
Just want to make sure it's pushed into the correct branch, I see "
grischi wants to merge 1 commit into TixiaoShan:master from grischi:ros2" on the top of this page, is it pushed to the master branch?

@grischi
Copy link
Collaborator Author

grischi commented Jun 11, 2021

I don't have permission to create a branch in your repo. I think you have to create such a branch, and then I can change the target branch of this PR.

@TixiaoShan
Copy link
Owner

@grischi
I have created a new branch called "ros2".

@grischi grischi changed the base branch from master to ros2 June 11, 2021 14:41
@TixiaoShan TixiaoShan merged commit 0f4908b into TixiaoShan:ros2 Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants