Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing header files in source package #9

Closed
toppk opened this issue Jun 18, 2024 · 1 comment
Closed

missing header files in source package #9

toppk opened this issue Jun 18, 2024 · 1 comment

Comments

@toppk
Copy link

toppk commented Jun 18, 2024

using python 3.12, and since there isn't a prebuilt wheel I pip is using the source ball, which only has yyjson.h and not document.h headers, as such I'm getting this error message:

  creating build/temp.linux-x86_64-cpython-312
  creating build/temp.linux-x86_64-cpython-312/yyjson
  gcc -fno-strict-overflow -Wsign-compare -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DNDEBUG -fcf-protection -fexceptions -fcf-protection -fexceptions -fcf-protection -fexceptions -fPIC -I/home/toppk/.py312/include -I/usr/include/python3.12 -c yyjson/binding.c -o build/temp.linux-x86_64-cpython-312/yyjson/binding.o
  yyjson/binding.c:4:10: fatal error: document.h: No such file or directory
      4 | #include "document.h"
        |          ^~~~~~~~~~~~
  compilation terminated.
  error: command '/usr/lib64/ccache/gcc' failed with exit code 1

adding the .h files in setup.py fixes that, but not sure if there's a better fix. let me know if you want a pr.

@TkTech
Copy link
Owner

TkTech commented Jun 19, 2024

Fixed and wheels for 3.12 building now.

@TkTech TkTech closed this as completed Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants