Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle connection events properly to reflect the real connection status #14

Closed
vinnylinck opened this issue Mar 31, 2014 · 1 comment
Closed
Milestone

Comments

@vinnylinck
Copy link

iOS implementation should check stream status before return Open Callback.

@vinnylinck vinnylinck added this to the v0.4.0 milestone Mar 31, 2014
@vinnylinck vinnylinck self-assigned this May 13, 2014
@vinnylinck
Copy link
Author

Once socket on iOS works with events, the proper implementation basically means:

  1. open socket connection
  2. returns OPEN operation status (if plugin connected successfully)
  3. When receiving the NSStreamOpen event, log that this connection was stablished.
  4. The event should change the "connected" flag
  5. Other events should be monitored to change the connection flag properly

As a result, isConnected method basically will returns the flag itself, making things simpler and increasing the accuracy of this information.

@vinnylinck vinnylinck changed the title Open status Handle connection events properly to reflect the real connection status May 13, 2014
vinnylinck added a commit that referenced this issue May 14, 2014
@vinnylinck vinnylinck reopened this May 14, 2014
@vinnylinck vinnylinck removed their assignment Mar 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant