Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CQ WW 160 #386

Merged
merged 5 commits into from
May 11, 2023
Merged

Add CQ WW 160 #386

merged 5 commits into from
May 11, 2023

Conversation

zcsahok
Copy link
Member

@zcsahok zcsahok commented Mar 26, 2023

Aiming to resolve #235.

First aligned the naming of spot.band with it actual use: it stores a band index (0,1,...), not a band (160,80,...). This was marked earlier in qso_from_spot(), where a temporary QSO is created for checking it for a new mult. Now qso->band contains the human readable band value (160,...).
Naming of freq2band() in bands.c was also fixed. (Sometime band index is referred to as band number, not easy to follow)

Next added setting of band value for a newly entered QSO. It is correctly filled in when reading the log, but was left out for new ones. Setting it in getexchange is just a stopgap measure: we shall in fact drop the global bandinx and use the one from current_qso instead.

@zcsahok
Copy link
Member Author

zcsahok commented Mar 26, 2023

Using simulated cluster spots:
image

  • DL would be a new country
  • TA has been worked already
  • AB3AH is in PA, already in log
  • AA3R is in DE, would be a new one

US states and Canadian counties are prefixed by their country prefix in order to separate them from DXCC prefixes.

After "working" AA1K (DE) AA3R is not marked as a mult.
image

@m5evt @N0NB may I ask you for a quick review?

@N0NB
Copy link
Member

N0NB commented Mar 26, 2023

LGTM

I don't recall if there is a need for separate rules for US/VE versus DXCC entries. It has been a few years since I operated in that 'test and I probably won't in the foreseeable future for various reasons.

@zcsahok
Copy link
Member Author

zcsahok commented Mar 26, 2023

Thanks, Nate. The purpose of prefixing is purely technical, e.g. to be able separate Ohio from Finland.

@dl1jbe
Copy link
Member

dl1jbe commented Apr 12, 2023

First aligned the naming of spot.band with it actual use: it stores a band index (0,1,...), not a band (160,80,...). This was marked earlier in qso_from_spot(), where a temporary QSO is created for checking it for a new mult. Now qso->band contains the human readable band value (160,...). Naming of freq2band() in bands.c was also fixed. (Sometime band index is referred to as band number, not easy to follow)

Thanks for sorting that out.

@zcsahok
Copy link
Member Author

zcsahok commented May 10, 2023

If there are no more comments then I'd merge this in.

@dl1jbe
Copy link
Member

dl1jbe commented May 11, 2023

Looks good. Go ahead.

@zcsahok zcsahok merged commit c33d43a into Tlf:master May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mults on bandmap with custom rules
3 participants