Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'units' are equal whether str or asunits.Unit when looking for conflicts #175

Merged
merged 1 commit into from
Nov 13, 2024
Merged

'units' are equal whether str or asunits.Unit when looking for conflicts #175

merged 1 commit into from
Nov 13, 2024

Conversation

Didou09
Copy link
Member

@Didou09 Didou09 commented Nov 13, 2024 •
edited
Loading

Main changes:

  • When looking for conflicts, there is now an exception for 'units':
    • if one dict has units as str
    • and the other as asunits.Unit
    • but they have the same str representation => they are considered equal

Issues:

Fixes, in devel, issue #174

@Didou09 Didou09 changed the title [#174] Fixed 'units' are equal whether str or asunits.Unit when looking for conflicts Nov 13, 2024
@Didou09 Didou09 merged commit 82e0c8b into devel Nov 13, 2024
12 checks passed
@Didou09 Didou09 deleted the Issue174_RobustUnitsCheck branch November 13, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Didou09 @dvezinet