Move colors and their handling in own translation unit and refactor them slightly #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request moves the handling of colors out of the
callbacks
translation unit into an ownscreentest_colors
one, since it seemed to not really fit there.As an experiment all heap-allocated data structures got moved to the stack. On one hand this simplifies memory handling, but on the other hand it's against the common usage pattern of GTK, so I'm a bit in doubt if this is a smart idea or not.
Lastly I added a
Doxyfile
for Doxygen. I don't intend to document the entire codebase, but still having it around shouldn't do harm.Just as information on my general intention: my plan is to work on #2 and #3 and maybe attempt to migrate to GTK 4 too. I stumbled across this blog post and since I like working on and reviving old codebases, I thought I'd tackle this challenge. I'm not keen on becoming a maintainer, but just want to make screentest fit for the next "20 years".