Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new test for find bright pixels (error pixels) of a lcd screen. #5

Merged
merged 3 commits into from
May 8, 2021

Conversation

ThKattanek
Copy link
Contributor

Hi! I have a new test added. This test is for finding error pixels from a LCD monitor. Cycle color red -> green -> blue -> white -> black.

Copy link
Owner

@TobiX TobiX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, just some minor nitpicks.

<child>
<object class="GtkRadioMenuItem" id="bright_pixels">
<property name="visible">True</property>
<property name="label" translatable="yes">Bright Pixels</property>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if "Solid color" would be the better label? Not sure about this myself 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Name is no matter. "Solid Color Cycle RGBWB". What ever ;)

test_basic.c Outdated Show resolved Hide resolved
@TobiX TobiX merged commit 2f35c2c into TobiX:master May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants