Fix: redshift leverages postgres adapter dispatch implementations for common functionality #2770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crericha
force-pushed
the
dispatch-macro-detection
branch
from
48c72ae
to
c1b60d9
Compare
izeigerman
reviewed
Jun 13, 2024
izeigerman
reviewed
Jun 13, 2024
izeigerman
reviewed
Jun 14, 2024
izeigerman
approved these changes
Jun 14, 2024
crericha
force-pushed
the
dispatch-macro-detection
branch
from
ee02d32
to
0595f4c
Compare
izeigerman
pushed a commit
that referenced
this pull request
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The redshift dbt adapter depends on the postgres adapter. For adapter dispatch, this means that postgres dispatch macros are valid when a corresponding redshift macro does not exist.
Note: The databricks adapter also depends on the spark adapter, so this fix applies there too.