Fix: cast NULLs in VALUES clause (df->values) to avoid coercion issues #2856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobymao
reviewed
Jul 4, 2024
| @@ -897,6 +897,14 @@ def select_from_values_for_batch_range( | |||
| ] | |||
|
|
|||
| values_exp = exp.values(expressions, alias=alias, columns=columns_to_types) | |||
| if values: | |||
There was a problem hiding this comment.
if we cast values, directly, do we need to also cast the select?
There was a problem hiding this comment.
are you referring to the projections? because we already cast them earlier in this function
There was a problem hiding this comment.
yea but now it's a double cast, cast in the values, and cast in the projection, should we just do one?
There was a problem hiding this comment.
Ah gotcha.. I guess we can try? I was being conservative because I'm not sure what the implications are in case we remove those casts, maybe we'll fail to infer the type of a projection down the line somewhere? On the other hand, we seem to have the columns_to_types mapping already, so perhaps it's fine.
tobymao
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2684
Gave it a whirl. Not sure if this is too intrusive to fix the linked issue - happy to discuss and refactor if needed.
cc @z3z1ma