Fix!: Send notifications for failing non-blocking audits from the builtin scheduler #2979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgesittas
approved these changes
Aug 2, 2024
Co-authored-by: Jo <46752250+georgesittas@users.noreply.github.com>
crericha
force-pushed
the
notify-non-blocking-audits
branch
from
0147577
to
71b7b1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the builtin-scheduler only sends notifications when the
SnapshotEvaluatorraises anAuditErrorexception, which only happens for failing, blocking audits.This PR addresses two things. First, it delays when the
AuditErroris raised, so that all of the snapshot's audits execute first and second, it sends notifications for all audits that failed, blocking or non-blocking.