Fix: User-provided plan end must take precedence over the max interval end per model #3042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
izeigerman
force-pushed
the
fix-user-provided-end-over-max-interval-end-per-model
branch
from
f2add93
to
9793f1d
Compare
tobymao
approved these changes
Aug 25, 2024
izeigerman
deleted the
fix-user-provided-end-over-max-interval-end-per-model
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last backfilled interval for each model should only be take into account if no explicit end date was provided by a user. Otherwise the user provided value should always take precedence.
This resolves the issue for seed models that have been backfilled once, models with an end date, and models with a broad execution cadence (e.g., monthly) where the start date value ends up being greater than the end date value.