Fix: Heuristics that determine the default start date of the forward-only preview plan #3043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…only preview plan
tobymao
reviewed
Aug 26, 2024
| default_end = None | ||
|
|
||
| default_start = to_date(default_end) - timedelta(days=1) if default_end and is_dev else None | ||
| default_start = to_date(min(max_interval_end_per_model.values())) - timedelta( |
There was a problem hiding this comment.
why don’t you need the else branch anymore?
There was a problem hiding this comment.
Because we initialize this value to None at the top. No need to set None again.
tobymao
approved these changes
Aug 26, 2024
izeigerman
deleted the
fix-default-start-inference-forward-only-preview
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should use the minimum value among the maximum interval end values to make a more accurate estimate for models whose cron is not aligned with a day boundary.