Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Test failure caused by a new version of rich #3053

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Fix: Test failure caused by a new version of rich #3053

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions tests/integrations/jupyter/test_magics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ def test_plan(
# the models and how long it took
assert len(output.stdout.strip().split("\n")) == 22
assert not output.stderr
assert len(output.outputs) == 5
assert len(output.outputs) == 4
text_output = convert_all_html_output_to_text(output)
# TODO: Is this what we expect?
# This has minor differences between CI/CD and local.
Expand All @@ -303,13 +303,11 @@ def test_plan(
)
# TODO: Is this what we expect?
assert text_output[2] == ""
assert text_output[3] == ""
assert text_output[4] == "The target environment has been updated successfully"
assert text_output[3] == "The target environment has been updated successfully"
assert convert_all_html_output_to_tags(output) == [
["pre", "span"],
["pre"] + ["span"] * 4,
["pre"],
["pre"],
["pre", "span"],
]

Expand Down