Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support external model dialects closes #3135 #3136

Merged
merged 1 commit into from
Sep 14, 2024
Merged

feat: support external model dialects closes #3135 #3136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions examples/sushi/external_models.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
- name: raw.demographics
description: Table containing demographics information
dialect: duckdb
start: 1 week ago
audits:
- name: not_null
Expand Down
8 changes: 5 additions & 3 deletions sqlmesh/core/loader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,12 +193,14 @@ def _load_external_models(self, gateway: t.Optional[str] = None) -> UniqueKeyDic
external_models: t.List[ExternalModel] = []
for row in YAML().load(file.read()):
model = create_external_model(
**row,
dialect=config.model_defaults.dialect,
defaults=config.model_defaults.dict(),
path=path,
project=config.project,
default_catalog=self._context.default_catalog,
**{
"dialect": config.model_defaults.dialect,
"default_catalog": self._context.default_catalog,
**row,
},
)
external_models.append(model)

Expand Down