fix: support all model methods in dbt projects #3161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobymao
force-pushed
the
toby/dbt_model
branch
2 times, most recently
from
2b91ed3
to
0814e81
Compare
izeigerman
reviewed
Sep 20, 2024
izeigerman
reviewed
Sep 20, 2024
tobymao
force-pushed
the
toby/dbt_model
branch
2 times, most recently
from
a685b0e
to
5047544
Compare
izeigerman
reviewed
Sep 20, 2024
| @@ -289,10 +294,21 @@ def sqlmesh_model_kwargs(self, context: DbtContext) -> t.Dict[str, t.Any]: | |||
| jinja_macros = model_context.jinja_macros.trim( | |||
| self.dependencies.macros, package=self.package_name | |||
| ) | |||
|
|
|||
| model_node: AttributeDict[str, t.Any] = AttributeDict( | |||
There was a problem hiding this comment.
btw, I don't think you need to convert to AttributeDict since the validator within JinjaMacros should take of that.
izeigerman
reviewed
Sep 20, 2024
izeigerman
reviewed
Sep 20, 2024
tests/dbt/test_manifest.py
Outdated
| @@ -31,6 +31,7 @@ def test_manifest_helper(caplog): | |||
| assert models["top_waiters"].dependencies == Dependencies( | |||
| refs={"sushi.waiter_revenue_by_day", "waiter_revenue_by_day"}, | |||
| variables={"top_waiters:revenue", "top_waiters:limit"}, | |||
| model_attrs={"columns"}, | |||
There was a problem hiding this comment.
can we also check some other attribute, eg. config?
izeigerman
approved these changes
Sep 20, 2024
tobymao
force-pushed
the
toby/dbt_model
branch
from
5047544
to
0af3faa
Compare
tobymao
force-pushed
the
toby/dbt_model
branch
from
0af3faa
to
6fa22cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.