Fix: regression caused by optionally normalizing identifiers in renderer #3165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
izeigerman
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts the
normalize_identifierschanges introduced in #3077. Switching off identifier normalization has unintended side effects, e.g.find_tablestreats CTE references like models if there's a casing mismatch, which can lead to more errors.The motivation was a unit testing issue where we raised an error saying that input data for a model was missing, even though it was a CTE that we knew how to populate.
Not sure if this PR is breaking, please let me know if you think of a case where we'd need a migration and I can update the title accordingly.