fix: more perf by offloading mork work to cores #3189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobymao
commented
Sep 26, 2024
tobymao
force-pushed
the
more_perf
branch
2 times, most recently
from
a1967d3
to
b9bce9c
Compare
izeigerman
reviewed
Sep 26, 2024
izeigerman
reviewed
Sep 26, 2024
izeigerman
reviewed
Sep 26, 2024
izeigerman
reviewed
Sep 26, 2024
sqlmesh/core/loader.py
Outdated
|
|
||
| model._data_hash = data_hash | ||
| model._metadata_hash = metadata_hash | ||
| model.update_schema(mapping_schema) |
There was a problem hiding this comment.
We wouldn't have to do this twice, if we were updating the schema prior to submitting a task like we used to
There was a problem hiding this comment.
we need to do it here on the computed mapping because it was done in a different process. we do it in the process so that we can leverage cores
izeigerman
approved these changes
Sep 26, 2024
two hot spots: model.update_schema was expensive because we had to generate sql for every column model._data_hash/_metadata_hash was expensive when calling context.snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.