fix!: correctly use execution time on new rows for scd type 2 by column #3192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eakmanrq
force-pushed
the
eakmanrq/fix_scd_type_2_column_behavior
branch
from
f889b61
to
f960fb6
Compare
eakmanrq
commented
Sep 27, 2024
| @@ -1364,6 +1364,7 @@ def test_scd_type_2_by_time(ctx: TestContext): | |||
| execution_time="2023-01-01 00:00:00", | |||
| updated_at_as_valid_from=False, | |||
| columns_to_types=input_schema, | |||
| truncate=True, | |||
There was a problem hiding this comment.
This properly mimics how the adapter will be used by truncating on first load and then not truncating on follow up load.
| @@ -1633,7 +1637,7 @@ def test_scd_type_2_by_column(ctx: TestContext): | |||
| "id": 5, | |||
| "name": "e", | |||
| "status": "inactive", | |||
| "valid_from": "1970-01-01 00:00:00", | |||
| "valid_from": "2023-01-05 00:00:00", | |||
There was a problem hiding this comment.
The prior value was a bug and this is it being fixed.
eakmanrq
force-pushed
the
eakmanrq/fix_scd_type_2_column_behavior
branch
from
f960fb6
to
75f5b78
Compare
tobymao
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects the SCD Type 2 By Column default behavior to use execution time for new rows after the table is initially loaded. This matches what the documentation example says it should behave. This does mean there is a behavior change for current users but the current behavior seems to be a bug. There is not a way for a user to maintain old behavior if they wanted it since we consider it a bug.
From reviewing the code,
truncateis a great way to identify if a table is being loaded for the first time. This also means that if a user issues a restatement on the table and wants to rebuild from scratch then it would also be set totruncateand would mimic loading the rows for the first time.